Unable to update jails with host built WITHOUT_FREEBSD_UPDATE

swills commented 3 years ago

Prerequisites

[X] Have you checked for an existing issue describing your problem?
[X] Are you running the latest version?

Describe the bug

A host built with WITHOUT_FREEBSD_UPDATE=yes doesn't have /usr/sbin/freebsd-update installed. This prevents updating jails that are created using ftp/http.

How to reproduce

Steps to reproduce the behavior:

Build host OS with WITHOUT_FREEBSD_UPDATE=yes set in /etc/src.conf, run make delete-old
Create poudriere jails with -m http
Later, try to update the jail using poudriere jail -u
See error: sed: /usr/sbin/freebsd-update: No such file or directory

Expected behavior

Poudriere uses /usr/sbin/freebsd-update from the jail to update the jail, instead of the one from the host, and the update succeeds.

Screenshots

sudo poudriere jail -u -j 130-amd64
[00:00:00] Upgrading using http
sed: /usr/sbin/freebsd-update: No such file or directory
13.0-RELEASE-p4
[00:00:00] Recording filesystem state for clean... done

Environment

Host OS [14-CURRENT amd64]:
Jail OS [12.2 amd64]:
Browser: [N/!]:
Poudriere Version [poudriere-devel-3.3.99.20211017_2]:
Ports branch and revision [N/A]:

Additional context

N/A

bdrewery commented 2 years ago

I'll try to add back compat for it. But it's such a small script why do we even allow not building it? Is there a concern about security or someone wrongly using it on the target system?

swills commented 2 years ago

I'll try to add back compat for it. But it's such a small script why do we even allow not building it? Is there a concern about security or someone wrongly using it on the target system?

I think it's a combination of vendors not wanting/needing it and potentially using it wrongly on systems built from source or using pkgbase. Which brings up a whole other issue of updating jails that are using pkgbase, but I suppose that's a separate issue to address later.

freebsd / poudriere