search

freechipsproject / chisel-bootcamp

Generator Bootcamp Material: Learn Chisel the Right Way
Apache License 2.0
982 stars 278 forks source link

Enhancements to Docker publish flow #136

Closed jackkoenig closed 3 years ago

jackkoenig commented 3 years ago

Proximate cause of this PR is that I typoed the Docker Hub organization name, it's ucbbar, not ucb-bar. I also noticed that there are security warnings when using docker/build-push-action@v1 so I updated to docker/build-push-action@v2. In the process, I figured we might as well build the Docker image in CI and only publish it on a push.

~Note: at the moment this will push for pull requests. I have it this way for testing. The TODO in docker.yml needs to be resolved before merge~ Done, it worked.

jackkoenig commented 3 years ago

I also went ahead and changed the secrets since, if there is a security flaw in docker/build-push-action@v1, I don't want the Access Token to leak out (and still be active) from the previous failed run on master.