search

freechipsproject / chisel-testers

Provides various testers for chisel users
Apache License 2.0
99 stars 50 forks source link

Use same ScalaTest version as ChiselTest #327

Closed schoeberl closed 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

ekiwi commented 2 years ago

Thanks @schoeberl . I just tested your chisel-book repository with the latest X.5-SNAPSHOT versions and the FlatSpec errors are gone. Some how there is not a deprecation warning though :(

schoeberl commented 2 years ago

I get deprecation warnings with ScalaTest:

[warn] /Users/martin/source/chisel-book/src/test/scala/WaveformTest.scala:8:28: type FlatSpec in package scalatest is deprecated (since 3.1.0): The org.scalatest.FlatSpec trait has been moved and renamed. Please use org.scalatest.flatspec.AnyFlatSpec instead. This can be rewritten automatically with autofix: https://github.com/scalatest/autofix/tree/master/3.1.x
[warn] class WaveformTest extends FlatSpec with ChiselScalatestTester {

So this looks good to me.