search

freechipsproject / diagrammer

Provides dot visualizations of chisel/firrtl circuits
Apache License 2.0
115 stars 20 forks source link

Add Github Actions CI (bp #75) #78

Open mergify[bot] opened 3 years ago

mergify[bot] commented 3 years ago

This is an automated backport of pull request #75 done by Mergify

Cherry-pick of 4b5f5ae70ed74aad58602c873b5dd2bbc268d2e5 has failed:

On branch mergify/bp/1.2.x/pr-75
Your branch is up to date with 'origin/1.2.x'.

You are currently cherry-picking commit 4b5f5ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

    deleted by us:   .github/workflows/test.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/
jackkoenig commented 3 years ago

@chick 1.2.x didn't have CI so Mergify/git was kind enough to turn this backport into just adding CI 🙂

jackkoenig commented 3 years ago

@chick a few tests fail with errors like:

[info] HierarchicalModulesExample:
[info] - This is an example of a module with hierarchical submodules  *** FAILED ***
[info]   java.io.IOException: Cannot run program "xdg-open": error=2, No such file or directory

Why isn't this an issue on 1.3.x?

chick commented 3 years ago

@jackkoenig It's a complete mystery, I'm trying to track this down now. xdg-open is mentioned only in one unused function in FirrtlDiagrammer object. I'm looking for clues still

chick commented 3 years ago

I thought this would be fixed by PR #80 which forced the diagram open program to "" for the tests. But CI still fails