search

freechipsproject / ip-contributions

For contributions of Chisel IP to the chisel community.
55 stars 9 forks source link

Added fixed point Finite Impulse Response filter. #32

Closed Kev-J closed 9 months ago

Kev-J commented 9 months ago

Fully pipelined FIR.

schoeberl commented 9 months ago

I propose that you use Scala/Java naming conventions and have the same spelling of the file name and the class name (Start with UpperCase).

ChiselEnum should now be in normal Chisel, no need for use of experimental.

Kev-J commented 9 months ago

Hello @schoeberl ,

I've fixed FIRFilter.scala and IIRFilter.scala filenames while I was at it.

Unfortunately, ChiselEnum is still in experimental package when using 3.5.5. To overcome this, we need to upgrade this package to 3.6.0.

Thanks for the review,

Kevin

schoeberl commented 9 months ago

You are right, ip-contribution is missing updates. It is on my TODO list.