search

freeconf / restconf

Implementation of RESTCONF Management protocol - IETF RFC8040
Apache License 2.0
29 stars 9 forks source link

fix: correct response to .well-known/host-meta (RFC 7033) #64

Closed b-kamphorst closed 4 months ago

b-kamphorst commented 4 months ago

Hi @dhubler,

While interacting with the FreeCONF server, we noted some issues in the response to /.well-known/host-meta. Specifically, it did not meet the specification of RFC 7033:

See also https://www.packetizer.com/json/jrd/ and the example in https://www.rfc-editor.org/rfc/rfc6415#appendix-A.

Please consider this PR :)

dhubler commented 4 months ago

Ok. Will review and likely merge this in, in next day. Thank you

On Tue, Jun 25, 2024, 5:19 AM bart @.***> wrote:

Hi @dhubler https://github.com/dhubler,

While interacting with the FreeCONF server, we noted some issues in the response to /.well-known/host-meta. Specifically, it did not meet the specification of RFC 7033 https://datatracker.ietf.org/doc/html/rfc7033#section-4.4:

  • incorrect top-level object xrd
  • missing required subject member
  • incorrect definition of links (should be an array with members)
  • incorrect @ in keys

See also https://www.packetizer.com/json/jrd/ and the example in https://www.rfc-editor.org/rfc/rfc6415#appendix-A.

Please consider this PR :)

You can view, comment on, or merge this pull request online at:

https://github.com/freeconf/restconf/pull/64 Commit Summary

File Changes

(2 files https://github.com/freeconf/restconf/pull/64/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/freeconf/restconf/pull/64, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACA7RQ7EBGYJRN7KOLBWTZJEY3JAVCNFSM6AAAAABJ3NP2UWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TEMJVGMZTCNY . You are receiving this because you were mentioned.Message ID: @.***>