search

freeconf / yang

Standards-based management for Golang microservices
Apache License 2.0
38 stars 15 forks source link

fix for bits type #103

Closed sibuk-harabudjasim closed 3 months ago

sibuk-harabudjasim commented 7 months ago

In manual tests came out that bits type was not properly cast. OnWrite function got uint64 instead of []string. This fix solves that.

dhubler commented 7 months ago

TBH, i think the uint64 probably is the right return for Value()

dhubler commented 7 months ago

Also, I noticed FreeCONF was missing support for BitList so I added it and thought following name changes would be better: Decimal -> Positions StringVals -> Labels I should have submitted a PR for you to review first but I ran short on time, sorry.

sibuk-harabudjasim commented 3 months ago

I suppose your solution fits better to library architecture. Closing this PR.