Allow read access to fmt.Stringer Keys and reference values on maps

[dhubler]

any chance you can add some test cases?

[HRogge]

I will try to add a few tests tomorrow... the changes itself look okay for you?

[dhubler]

yes.

On Thu, Aug 25, 2022 at 8:50 AM Henning Rogge @.***> wrote:

I will try to add a few tests tomorrow... the changes itself look okay for you?

— Reply to this email directly, view it on GitHub https://github.com/freeconf/yang/pull/27#issuecomment-1227215194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACA7XBY2XJSH4XXDRBPNTV25T2HANCNFSM57R33LXA . You are receiving this because you commented.Message ID: @.***>

[HRogge]

fun fact about the tests for keys of maps. The sort API of go doesn't call the comparator for slices with length 0 or 1, so it never fails with a "bad type" unless the map contains at least two elements.

[dhubler]

feature ;)

all the pieces look there. i'll run test and merge this in this evening.

On Fri, Aug 26, 2022 at 2:30 AM Henning Rogge @.***> wrote:

fun fact about the tests for keys of maps. The sort API of go doesn't call the comparator for slices with length 0 or 1, so it never fails with a "bad type" unless the map contains at least two elements.

— Reply to this email directly, view it on GitHub https://github.com/freeconf/yang/pull/27#issuecomment-1228107721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACA7R4ENJKG725EZIY26LV3BP6TANCNFSM57R33LXA . You are receiving this because you commented.Message ID: @.***>

[HRogge]

I have code for doing the write access for custom typed fields (without writing custom handlers)... do you want to merge this and take the new one in a new pull request?

[dhubler]

yes, merging in would be better.

On Tue, Aug 30, 2022 at 7:05 AM Henning Rogge @.***> wrote:

I have code for doing the write access for custom typed fields (without writing custom handlers)... do you want to merge this and take the new one in a new pull request?

— Reply to this email directly, view it on GitHub https://github.com/freeconf/yang/pull/27#issuecomment-1231511016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACA7UOAPANQKFVO74YZ7TV3XTG5ANCNFSM57R33LXA . You are receiving this because you commented.Message ID: @.***>

[HRogge]

I have pushed a branch called custommarshallerpreview to my own repository so you can have a look what comes next. I will rebase it to "master" and send a pull request for it as soon as this pull is merged.

[dhubler]

I was thinking you'd squash the 2 commits on your end and submit a single, cohesive PR that supports r/w for structs and stringers

On Wed, Aug 31, 2022 at 12:43 AM Henning Rogge @.***> wrote:

I have pushed a branch called custommarshallerpreview to my own repository so you can have a look what comes next. I will rebase it to "master" and send a pull request for it as soon as this pull is merged.

— Reply to this email directly, view it on GitHub https://github.com/freeconf/yang/pull/27#issuecomment-1232455330, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACA7VHYV5U6BK6D3XQ2XLV33PFNANCNFSM57R33LXA . You are receiving this because you commented.Message ID: @.***>

[HRogge]

if you prefer the change (r/w) as a single commit, I can squash them all and open a new PR.