search

freedomjs / freedom-pgp-e2e

Wrapping up end-to-end code and provide in freedom custom API.
34 stars 6 forks source link

Result of verify+decrypt doesn't include full signer info #14

Closed willscott closed 9 years ago

willscott commented 9 years ago

Created an ID as Will Scott <willscott@fakeemail.com> sign+encrypt a message, then decrypt+verify it, all on the same instance.

The resulting signer returned by the final call is ["Will Scott "]. It seems like we would like a. trim the user name to not have the subsequent space, and b. also include the full userID here.

agallant commented 9 years ago

Looks like an escaping issue, I think this addresses it: https://github.com/freedomjs/freedom-pgp-e2e/commit/8683f0424cffe96c7cbd0d101a1bcef4d60f6e91

There are potentially other ways to deal with escaping HTML but from what I could read this is "the right way" in that it trusts a browser primitive. LMK if this addresses it for you or not, thanks!

willscott commented 9 years ago

Cool!