search

freedomjs / freedom-pgp-e2e

Wrapping up end-to-end code and provide in freedom custom API.
34 stars 6 forks source link

Node 0.12 compatibility #21

Closed agallant closed 9 years ago

agallant commented 9 years ago

The module and integration tests run in node 0.10, but in 0.11 hit a C-level error: grunt: symbol lookup error: /home/travis/build/freedomjs/freedom-pgp-e2e/node_modules/freedom-for-node/node_modules/ws/build/Release/bufferutil.node: undefined symbol: _ZN2v86Object3SetENS_6HandleINS_5ValueEEES3_NS_17PropertyAttributeE

This issue would likely affect other freedom-for-node modules with node 0.11, but filing the issue here for now as this is where it's verified. Ideally this is an error beneath us in the stack that we shouldn't have to directly fix.

Some more references: -Actual execution: https://travis-ci.org/freedomjs/freedom-pgp-e2e/jobs/47718765#L261 -Discussion of a similar error: https://github.com/charlieroberts/interface.server/issues/2 (but we don't want to take this fix as we're not actually running nw ourselves)

agallant commented 9 years ago

Node 0.12 (stable) has been officially released (http://blog.nodejs.org/2015/02/06/node-v0-12-0-stable/) so I'm retargeting this issue. Of particular note, the change list includes some notes about crypto (e.g. "Added APIs for RSA public/private key encryption/decryption") - but those will probably mean a different shim/provider, and maybe even be something we have to shadow for the e2e provider.

agallant commented 9 years ago

Deferring as non-priority, it's probably "close enough" to working and it's more worth focusing on io.js when stable.