Code review

[kennysong]

Refactored significantly for code review.

[mollyling]

LGTM, small comments inline.

---

Review status: 0 of 8 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

^{src/nat-pmp.js, line 233 [r1] (raw file):} Btw, the array buffer's pre-initialized to zero, so these zero-valued rows are unnecessary.

---

^{src/pcp.js, line 255 [r1] (raw file):} As above, these zero-valued rows aren't needed.

---

^{src/utils.js, line 114 [r1] (raw file):} Two small things:

• Note that the ArrayBuffer is initialized to zero already (in the docs here)
• in the if/else if/.. below, have a final else { .. } that prints an error to the console. It's nice to report errors.

---

Comments from the review on Reviewable.io

[mollyling]

Reviewed 8 of 8 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[kennysong]

Review status: 5 of 8 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

^{src/nat-pmp.js, line 233 [r1] (raw file):} Done.

---

^{src/pcp.js, line 255 [r1] (raw file):} Done.

---

^{src/utils.js, line 114 [r1] (raw file):} Done.

---

Comments from the review on Reviewable.io