search

freedomjs / freedom-social-firebase

Firebase Social Provider
0 stars 0 forks source link

Fix missing profile links #39

Closed dborkan closed 8 years ago

dborkan commented 8 years ago

Fixes https://github.com/uProxy/uproxy/issues/2303, along with https://github.com/uProxy/uproxy/pull/2363

Profile URLs were no longer properly retrieved after changes to add invites. Now we get profile URLs the same way we get images, by having each logged in user post their own URL to their .../profile/ location on the Firebase server.

Tested in Chrome w/ Gmail and Facebook networks.

Note after this fix, you will still only see profiles for users who have logged in after getting the fix. i.e. if Alice and Bob are already friends, and Alice logs in with this fix, then afterwards Bob logs in with this fix, Bob will see Alice's profile, but Alice still won't see Bob's profile under after logging out then logging back in again.

dborkan commented 8 years ago

Just realized there is a problem with this (profiles can be spoofed). Will fix this in a bit, no need to review yet..