search

freedomjs / freedom

Embracing a distributed web
http://freedomjs.org
Apache License 2.0
515 stars 52 forks source link

Change build process to support unicode #287

Closed agallant closed 8 years ago

agallant commented 9 years ago

Right now we're explicitly restricting our code to ascii so sourcemaps work (see #286). When dependencies align happily, we should remove this restriction.

willscott commented 9 years ago

what needs to happen to do this? would this be transform in browserify to just remove non-ascii characters?

agallant commented 9 years ago

Ideally the main thing to change on our end is just remove the replace task - I believe the issue is a bug propagating across various browserify related dependencies, and that with a bit of time it may just be resolved. That said, I'll check in on it periodically and if that's not happening then I'll revisit in more depth.

agallant commented 9 years ago

Periodic check, issue still live so keeping the replace task.

agallant commented 8 years ago

Issue still live - if I get a chance at this point I may look into fixing it upstream.