Fix integration tests post lazy module loading

freedomjs / freedom

Embracing a distributed web

http://freedomjs.org

Apache License 2.0

512 stars 53 forks source link

Fix integration tests post lazy module loading #312

Closed agallant closed 8 years ago

agallant commented 8 years ago

Currently 12 integration tests fail - https://app.shippable.com/runs/5727d55199e6210c008cda93

It looks like errors often have to do with testing broken dependencies (https://github.com/freedomjs/freedom/blob/ead1ece1c47085d73214a02010a8d2af7ad00a3f/spec/helper/environment.js#L47) as well as timeouts, so possibly the new lazy approach is causing state to "leak" a bit across tests.

agallant commented 8 years ago

@bemasc I'm trying to debug this but curious on your thoughts/experience. Did/do these tests pass for you locally? I see you touched many of the related files, and while it looks like the tests you added pass several of the ones above it now seem to fail.

bemasc commented 8 years ago

Yep, grunt test passes locally with 296 SUCCESS and 106 SUCCESS.

agallant commented 8 years ago

Very odd - I get the same 12 failures as on Shippable, both natively on OSX and in an Ubuntu 14.04 VM. Travis looks to only be running the 150 unit tests and not the integration tests, and those all pass locally/on Shippable as well.

I'm generally testing in stable-or-newer node, Firefox, and Chrome - I assume you are as well, but if you happen to be running really old node or something let me know. Thanks.

bemasc commented 8 years ago

I'm using:

node 0.10.25
Firefox 46.0
Chromium 49.0.2623.108
Ubuntu 14.04
Fresh install of all npm dependencies

grunt test-phantom says

PhantomJS 2.1.1 (Linux 0.0.0): Executed 148 of 150 (skipped 2) SUCCESS (0.848 secs / 0.844 secs)

bemasc commented 8 years ago

Solved. I forgot to git add a new file. :-(

agallant commented 8 years ago

No worries, thanks for catching!