search

freedomjs / freedom

Embracing a distributed web
http://freedomjs.org
Apache License 2.0
512 stars 53 forks source link

Soycode peerconnection #316

Closed agallant closed 8 years ago

agallant commented 8 years ago

Makes core.peerconnection depend on the webrtc-adapter fill, which is also what core.rtcpeerconnection depends on. Related to #152.

agallant commented 8 years ago

Related topic - https://github.com/willscott/webrtc-adapter/issues/9 - if we make the adapter directly support node it may be a good way to generalize the fill.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 80.942% when pulling 8625b866da2ce30f5a99cf148de2432519d208d6 on soycode-peerconnection into f9661579347a928500ef31f0fb019846f9b33555 on master.

willscott commented 8 years ago

i thought the goal of #152 was to fully kill off the old core.peerconnection api, and the way to do that was to take the smarter stuff like chunking in there and have it as a freedom module that relies on core.rtcpeerconnection?

agallant commented 8 years ago

Agreed on the first part (the full goal is to get rid of core.peerconnection), didn't know the second part. I'll take a fresh look through some of the linked issues, but it sounds sensible.