search

freedomjs / freedom

Embracing a distributed web
http://freedomjs.org
Apache License 2.0
515 stars 52 forks source link

Soycode nodewrtc #317

Closed agallant closed 8 years ago

agallant commented 8 years ago

Companion pull request for https://github.com/freedomjs/freedom-for-node/pull/40

Test and implementation tweaks so core.rtcpeerconnection works in node.

willscott commented 8 years ago

seems okay. again, checkCI

agallant commented 8 years ago

Shippable passes, Travis failures seem related to Saucelabs timeouts and not any of this change. Will give it a few more pokes but likely merge later today/early Monday to line up with other things.

agallant commented 8 years ago

Verified that the Travis failures also happen on the master branch (which was passing on Travis ~2 weeks ago), so this is probably a regression somewhere in our testing setup (i.e. Saucelabs). I'm not too familiar with that part of the CI, so since tests pass locally and on Shippable I'm going to merge this for now and will look into fixing Saucelabs separately.