search

freedomjs / freedom

Embracing a distributed web
http://freedomjs.org
Apache License 2.0
512 stars 53 forks source link

disable saucelabs #320

Closed agallant closed 8 years ago

agallant commented 8 years ago

Fix #319

I spent some time trying to persuade Sauce Labs to pass (https://github.com/freedomjs/freedom/tree/soycode-fixtests) but it's a bit opaque so I'm tempted to just call it, at least temporarily. I'll open a "re-enable saucelabs" issue after merging this, but I think it's better to have (informative) green tests than weird failures because Chrome 54 does something strange in Sauce Labs.

Assigning to you Ray as I think you set up Sauce Labs so you may have more insight on this. Thanks!

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling c9e63cefdb20bc92d7846ec97ea654615125b147 on soycode-disablesaucelabs into \ on master**.

agallant commented 8 years ago

Just to update - looks like similar tests still fail on regular old Shippable, and on Chrome versions as early as 52. Still a pretty opaque failure (timeout on a fairly simple fundamental test), but worth investigating Chrome changelogs and similar to figure out. Hopefully fixes Saucelabs as well.

agallant commented 8 years ago

Alright, belaying this on a hopeful fix for Chrome 52. May end up cutting a release regardless, as whatever the issue is it's not related to recent changes.