search

freedomjs / freedom

Embracing a distributed web
http://freedomjs.org
Apache License 2.0
512 stars 53 forks source link

Add a core.online provider to monitor online status #325

Closed bemasc closed 7 years ago

bemasc commented 7 years ago

This is essentially a workaround for https://crbug.com/114475

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 149273bbc70c190d1af8336e492cd7141737289b on bemasc-online into \ on master**.

bemasc commented 7 years ago

I added a comment in answer to your question. PTAL.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling fb9f4e12beb8737f1c1823cc1856a3accd46e4a9 on bemasc-online into \ on master**.

agallant commented 7 years ago

LGTM :+1: - and to verify I understand your comment, it sounds like this will still be useful in some cases even after the bug is resolved. I also assume we want to expose this in freedom-for-* flavors and cut new releases, let me know if you'd like me to do that or if you'll send pull requests. Thanks!

bemasc commented 7 years ago

it sounds like this will still be useful in some cases even after the bug is resolved

Yeah ... maybe. There's no event to listen for, so I guess you'd have to poll navigator.onLine, unless there's some tricky solution using Object.observe() or something. Also, the bug has been open for four years and no one's working on it.

bemasc commented 7 years ago

I also assume we want to expose this in freedom-for-* flavors and cut new releases, let me know if you'd like me to do that or if you'll send pull requests.

It would definitely be helpful if you could handle the release sequence. Thanks!