search

freedomjs / freedom

Embracing a distributed web
http://freedomjs.org
Apache License 2.0
515 stars 52 forks source link

add npm shrinkwrap (freeze dependencies) #330

Closed agallant closed 7 years ago

agallant commented 8 years ago

Fix #311

Dependencies are fairly fresh, things that are held back are chosen on purpose (so that build/tests still work).

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 81.17% when pulling 1e6c138fb11107f8835fd208c06ab3e52cc35f11 on soycode-npmshrinkwrap into 27f710b9383ce6fa701941b039a298e436764ef7 on master.

agallant commented 8 years ago

Assigning you all as FYI and consensus check - freedom.js has been pretty stable, and I think locking down the dependencies is a good bet. If anyone has objections please let me know by early next week - I intend to cut a release Wednesday morning at latest and merge this before doing so.

willscott commented 8 years ago

seems reasonable. :+1:

On Fri, Oct 07, 2016 at 12:39:52PM -0700, soycode wrote:

Assigning you all as FYI and consensus check - freedom.js has been pretty stable, and I think locking down the dependencies is a good bet. If anyone has objections please let me know by early next week - I intend to cut a release Wednesday morning at latest and merge this before doing so.

You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/freedomjs/freedom/pull/330#issuecomment-252343018

agallant commented 8 years ago

Hrm, that said it seems like "just add npm-shrinkwrap.json" breaks fresh installation in CI. Will update once I figure out the conflict.

agallant commented 8 years ago

Should be resolved - fsevents is an optional OSX-specific package that gets thrown in when you use npm on a Mac. Did npm install --no-optional instead of the regular npm install before shrinkwrapping, and now the result should be Linux-friendly.

The actual error for future search friendliness - "Not compatible with your operating system or architecture: fsevents@1.0.14"

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 81.17% when pulling 568d97425ba2fb1b71c9484e213fea11c3668cdc on soycode-npmshrinkwrap into 27f710b9383ce6fa701941b039a298e436764ef7 on master.

agallant commented 7 years ago

Just to update/document - the plan is to merge this, cut a release, do similar bumping/freezing of the freedom flavors and cut those releases as well. I'll be working with @rajasagashe as he'll be taking over some of this (though his immediate focus will be node-wrtc related).