search

freedomlayer / offset

Offset payment engine
https://www.offsetcredit.org
Other
164 stars 20 forks source link

Rename crypto_rand.rs to rand.rs in crypto and other crates #212

Closed Atul9 closed 5 years ago

Atul9 commented 5 years ago

closes #210

Atul9 commented 5 years ago

@realcr does this https://travis-ci.com/freedomlayer/offst/jobs/206612603 build fail since cargo-sweep already exists in destination`? Please suggest the changes which can I make to get the build passed.

pzmarzly commented 5 years ago

No, it fails at cargo fmt. Just run cargo fmt and make a commit.

cargo-sweep is just a warning, though that's not clear at the first glance. I will change that.

Atul9 commented 5 years ago

@pzmarzly @realcr I have updated the PR, please review.

realcr commented 5 years ago

@pzmarzly : Thanks for helping out!

@Atul9 : Thank you for your contribution, highly appreciated! One thing that can be useful in the future: Offst is a project with multiple crates. I think that if you run cargo fmt from the root directory it can fix the formatting in all crates at once. I also believe it is reasonable to have just a single commit for running cargo fmt for the whole project.