search

freedomlayer / offset

Offset payment engine
https://www.offsetcredit.org
Other
163 stars 20 forks source link

Improve cargo-sweep.sh #214

Closed pzmarzly closed 5 years ago

pzmarzly commented 5 years ago

See conversation in #212. cargo-sweep will no longer print "error" when cargo-sweep is already installed. Also, updating it should now work.

realcr commented 5 years ago

@pzmarzly : Thanks, I will merge this. I noticed some strange error in one of the integration tests in macOS, I try to restart it. I will check it later and fix if necessary in another PR.

pzmarzly commented 5 years ago

I also experienced the same issue in #215 after Apply cargo fmt commit, restarting the macOS job helped.

realcr commented 5 years ago

I also experienced the same issue in #215 after Apply cargo fmt commit, restarting the macOS job helped.

I added some code to document what happens in the bad integration test (On MacOS). Next time it happens could you include the error? I'm very interested to see what happens there. My guess is some kind of networking problem.

realcr commented 5 years ago

@pzmarzly : I think that I fixed the macOS bug, but I accidentally pushed the fix directly into master. Sorry about that \:

pzmarzly commented 5 years ago

Ready for merging

realcr commented 5 years ago

@pzmarzly : Thanks! Could you check my question above about duplicate if clause in the bash script? Is there a way we can make it more compact? EDIT: Only now I realized I didn't click on the "request changes". Maybe my question wasn't visible until now (: Sorry!

realcr commented 5 years ago

@pzmarzly : Thanks!