freedomlayer / offset

Offset payment engine
https://www.offsetcredit.org
Other
164 stars 20 forks source link

serde_derive not required in 2018 edition #234

Closed cy6erlion closed 5 years ago

cy6erlion commented 5 years ago

232

realcr commented 5 years ago

Hi, thank you for your work on this! I just checked, this seems to be the reason for compilation failure:

   Compiling offst-database v0.1.0 (/home/travis/build/freedomlayer/offst/components/database)

error[E0463]: can't find crate for `serde_derive`

  --> components/database/src/lib.rs:17:1

   |

17 | extern crate serde_derive;

   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

I am on a less capable device right now, I suggest to take a look at database/src/lib.rs and see if you can omit the extern crate serde_derive; line. Did this code compile on your machine?

cy6erlion commented 5 years ago

This is strange, it does compile on my machine, I think this is how I missed it. But the other crates did not build when extern crate serde_derive; was present I had to change it to extern crate serde . I will change it in database/src/lib.rs as well.

cy6erlion commented 5 years ago

Updated it to extern crate serde