freedomofpress / ansible-role-grsecurity

The documentation and build system for the grsecurity kernel maintained by the Freedom of the Press Foundation for SecureDrop
GNU General Public License v2.0
49 stars 13 forks source link

Namespace default vars in install role #45

Closed conorsch closed 8 years ago

conorsch commented 8 years ago

Prefixes default vars for the install role with grsecurity_install_. Doing so avoids variable collisions, in the very real example of variable reuse—the build and install role both had a var called grsecurity_deb_package and site-wide declarations of that var broke one of the roles, depending on which meaning you used.

The var is now called grsecurity_install_deb_package; a separate PR can namespace the build-role vars, before for now it's enough that they're distinct. Updated all instances and added some helpful comments.