search

freedomofpress / ansible-role-grsecurity

The documentation and build system for the grsecurity kernel maintained by the Freedom of the Press Foundation for SecureDrop
GNU General Public License v2.0
49 stars 13 forks source link

Ensure configure tasklisk skipped when no custom config is passed #84

Closed psivesely closed 8 years ago

psivesely commented 8 years ago

Setting grsecurity_build_custom_config to an empty str instead of None matches the conditional statments in the main.yml of the grsec-build role. This way, the configure and compile taskslists get skipped, and the running the role with the manual strategy works as intended, instead of ending in failure.

conorsch commented 8 years ago

See 9d1c7b2f139627dc9792a56ad14134f0e5a6ba26. It would be grand if we had an automated test suite to guard against regressions down the various logic paths the config can take us, but we're not there yet, and heavy manual testing is required to make sure changes don't break.