search

freedomofpress / ansible-role-jitsi-meet

Installs the Jitsi Meet open source videoconferencing software
23 stars 26 forks source link

Uses stable apt repository by default #27

Closed conorsch closed 7 years ago

conorsch commented 7 years ago

The Jitsi Meet project offers both stable and nightly builds via apt repository. These changes update the default role behavior to use the stable apt repos, but still support using the nightly repos if the churn is preferred.

Includes a few updates to test suite, as well—these changes should be tested fully prior to merge.

conorsch commented 7 years ago

Rebased on top of latest master. Refined logic for choosing between stable-versus-unstable apt repo, currently defaulting to stable. Using a vars dict in defaults to associate repo URLs and repo key IDs, since the stable repo uses a different key. Updated tests to match.

conorsch commented 7 years ago

The crafty with_dict pragma using None for unwanted params fails under Ansible v2.2—older versions work fine. Will need to take another pass and get it working under multiple versions.

msheiny commented 7 years ago

dude, ive been using jinja filter |default(omit) which is amazing

conorsch commented 7 years ago

@msheiny Thanks for the recommendation, will take a crack at using omit for compatibility with multiple v2 versions of Ansible.

conorsch commented 7 years ago

Simpler than I'd anticipated, since both the stable and unstable repos are now signed by the same Jitsi Dev GPG key. @msheiny can you review again? You should be able to run:

molecule test --destroy never

And have it complete successfully, including all tests passing. Make sure to test both Ansible v2.2 and v2.1.1 and let me know if you can get anything to break.

msheiny commented 7 years ago

Yeah seems to be "working" good on my end for 2.2 so far... I mean it passes the tests and is idempotent but I was attempting to connect one browser session to the port forward and it seemed to freeze up. I suspect this has to do with the port forwarding and the client code trying to connect back to the server on the wrong port.

Running through with ansible 2.1 now..

msheiny commented 7 years ago

Looks good to me so far... It's up to the cloud gods now to see how it works in prod.

sad_ops

conorsch commented 7 years ago

Thanks, @msheiny! Going in. :rocket: :shipit: