search

freedomofpress / ansible-role-jitsi-meet

Installs the Jitsi Meet open source videoconferencing software
23 stars 26 forks source link

Moves the port 5347 checks to the prosody spec file. #34

Closed bgrozev closed 7 years ago

bgrozev commented 7 years ago

The check for port 5347 was duplicated in the jicofo and the videobridge spec files. It seems best suited for the prosody spec file, since prosody is the process which binds on the port.

bgrozev commented 7 years ago

Note that I haven't tested this, as I don't have a suitable environment.

conorsch commented 7 years ago

Thanks, stepping through the tests now. Have a local branch lying around that converts the test suite to testinfra, so rigging up the serverspec env now. The changes look quite clear, but I'll make sure to verify locally prior to merge, since the tests aren't running automatically via CI.

conorsch commented 7 years ago

@bgrozev These updates are great. Thanks very much for the clarification in the comments as well, it makes the tests more readable and discoverable. Will port these changes over to a test suite that runs via CI in the near future.