search

freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs
https://dangerzone.rocks/
GNU Affero General Public License v3.0
3.37k stars 153 forks source link

Prevent FIXUP commits from being merged #710

Closed deeplow closed 4 months ago

deeplow commented 4 months ago

Add a GitHub action that prevents merging if FIXUP is found the PR branch. This has happened twice recently and because our main is protected, this gets written to history.

apyrgio commented 4 months ago

@deeplow has added a CI check that fails if there's a commit with WIP/FIXUP in its title. It doesn't prevent pushes, but it's a good visual warning so that developers don't push to main, much as failing lints are.

deeplow commented 4 months ago

Thanks for closing this. For context this was implemented in https://github.com/freedomofpress/dangerzone/pull/711