search

freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs
https://dangerzone.rocks/
GNU Affero General Public License v3.0
3.36k stars 153 forks source link

Add support for Ubuntu 24.04 (Noble) and Fedora 40 #779

Closed apyrgio closed 2 months ago

apyrgio commented 2 months ago

This PR adds support for Ubuntu 24.04 (Noble) and Fedora 40. Code-wise, thankfully, we don't need to make a change, but we still need to extend our CI scripts.

Unfortunately, we are unable to build Dangerzone .deb packages in Ubuntu Noble. Still, this issue does not really bite us yet, since we build production .deb packages in Debian Bookworm, and our tests already cover that.

[!NOTE] This PR should be merged after #778.

Refs #773 Closes #762

apyrgio commented 2 months ago

Thanks for the extra :eyes: @naglis, super appreciated!

apyrgio commented 2 months ago

Shouldn't we also have .github/workflows/check_repos.yml

Yeah, but since those two are new distros, there's no Dangerzone package in them. We have to add this check after the release. I can track it in a separate issue, if you prefer.

BUILD.md has a note about Ubuntu 22.04 having issues with conmon. Have you checked if this also applies to 24.04? (I suspect it has a recent enough version, but just wanted to note it)

Yeap, I've checked and we're good.

RELEASE.md we could bump latest version names (both for ubuntu and fedora) just so the instructions don't feel outdated. In practice this doesn't make much of difference.

Hm, those versions are not out yet, so at the time of writing this, Fedora 39 and Ubuntu 22.04 are still the correct choices. Still, this is not a user-facing doc, so we can break the rules a bit and future-proof it. Fixed in 7f39669a9c7b460887f449179b5b957f5da46756.

deeplow commented 2 months ago

Shouldn't we also have .github/workflows/check_repos.yml

Yeah, but since those two are new distros, there's no Dangerzone package in them. We have to add this check after the release. I can track it in a separate issue, if you prefer.

The thing is that this is bumping INSTALL.md, but if we end up not publishing for these platforms due to blockers, it shouldn't be listed there.

apyrgio commented 2 months ago

The thing is that this is bumping INSTALL.md, but if we end up not publishing for these platforms due to blockers, it shouldn't be listed there.

We discussed this out of band. @deeplow was referring to this blocker:

Unfortunately, we are unable to build Dangerzone .deb packages in Ubuntu Noble. Still, this issue does not really bite us yet, since we build production .deb packages in Debian Bookworm, and our tests already cover that.

The thing here is that end-users are not affected by this issue. Only Ubuntu 24.04 (Noble) users who want to build this package from source. So, it's ok to start supporting this platform, even if #773 is not resolved yet.

With that covered, I have the green light to merge the PR.

deeplow commented 2 months ago

Approved, pending the lint fix.