freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs
https://dangerzone.rocks/
GNU Affero General Public License v3.0
3.58k stars 168 forks source link

Use `%F` field code in .desktop entry #798

Closed naglis closed 4 months ago

naglis commented 5 months ago

On Linux, the %u field code results in multiple Dangerzone instances being launched when opening multiple documents with Dangerzone from e.g. Nautilus, as %u signifies that the application (in this case - Dangerzone) can only open a single file/URL at once.

This changes the field code to %F as Dangerzone (now) supports converting multiple files at once. We use %F (multiple local files) instead of %U (multiple files and/or URLs) since Dangerzone does not support opening URLs.

See also the Desktop Entry Specification for more information on the field codes.

Fixes #797

apyrgio commented 4 months ago

Merged, with an additional changelog item:

  • Linux: Allow opening multiple files at once, when selecting them from the user's file manager (issue #797)

(I'll add proper attribution after prior to the release, sorry for missing that...)

Also, I tested on macOS and it seems that it's bitten by a similar problem, albeit in a different way (see https://github.com/freedomofpress/dangerzone/issues/800). If the fix is trivial, I'll try to include it in the 0.6.1 release.