search

freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs
https://dangerzone.rocks/
GNU Affero General Public License v3.0
3.35k stars 152 forks source link

Use `LF` line-ending for `gvisor_wrapper/entrypoint.py` #838

Closed almet closed 1 week ago

almet commented 1 week ago

Otherwise, Dangerzone images built on Windows might not be able to work, as they cannot load the entrypoint file, triggering an error.

almet commented 1 week ago

One test is failing: 

FAILED tests/test_cli.py::TestExtraFormats::test_hancom_office[sample-hwp.hwp] - assert 1 == 0
 +  where 1 = <CLIResult SystemExit(1)>.exit_code

I was surprised the CI didn't catch this error (the image built from windows not being functional).

The current CI tests do not build the images, which makes the CI faster, but also doesn't catch some errors, like this one.

I see multiple good reasons ( :polar_bear: :ice_cube:, :hourglass_flowing_sand:) for using DUMMY_CONVERSION = 1 in some builds, but it might also prove useful to build the image from windows and/or macOS once in a while.

apyrgio commented 1 week ago

Thanks for the change Alexis. Hopefully we won't have to deal with it again. Feel free to merge!