search

freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs
https://dangerzone.rocks/
GNU Affero General Public License v3.0
3.35k stars 152 forks source link

Provide a seccomp policy on docker if using "old" version of runc #845

Closed almet closed 6 days ago

almet commented 1 week ago

That's what I have, @apyrgio. I renamed the "runtime" references to "container_engine" in the hopes of making it clearer, and added a "get_runtime_version" static method.

Not much, but that's a start :-)

apyrgio commented 6 days ago

I have sent a PR (#847) which does things a bit differently than this one. The most important distinction is that it does not use the runc runtime version for compatibility checks, so we don't need to refactor our code to change references from "container runtime" to "container engine".

To be honest though, this is a fair point, we should do it at some time.