search

freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs
https://dangerzone.rocks/
GNU Affero General Public License v3.0
3.73k stars 172 forks source link

Fix wrong container runtime detection on Linux #906

Closed almet closed 2 months ago

almet commented 2 months ago

This is still a work in progress, not ready to be merged.

Fixes #212

almet commented 2 months ago

Updated, this now looks like this:

image

This still needs to be more consistent between the different OSes, and probably display the error on other platforms.

almet commented 2 months ago

This now looks like this:

image

almet commented 2 months ago

While reviewing the issues that should be included in 0.8.0, I found about https://github.com/freedomofpress/dangerzone/issues/193, which is about displaying errors to the end user.

I'm now thinking that the code introduced here to display the logs might be put in a sort of component, to be reused on other parts of the client UI.

apyrgio commented 2 months ago

Thanks Alexis, feel free to merge, I guess once the CI is working once more.