Always use our own seccomp policy as a default.

freedomofpress / dangerzone

Take potentially dangerous PDFs, office documents, or images and convert them to safe PDFs

https://dangerzone.rocks/

GNU Affero General Public License v3.0

3.73k stars 172 forks source link

Always use our own seccomp policy as a default. #926

Closed almet closed 1 month ago

almet commented 2 months ago

As per Etienne Perot's comment on #908:

Then it seems to me like it would be easy to simply apply this seccomp profile under all container runtimes (since there's no reason why the same image and the same command-line would call different syscalls under different container runtimes).

As mentioned in the comments there, we might want to tighten the default seccomp policy, to have more control on what we accept or not.

Fixes #908

apyrgio commented 1 month ago

I took the liberty to make some rewordings in the PR, in a separate fixup commit. Also, I've commented on the original issue about our change of course on this subject (see https://github.com/freedomofpress/dangerzone/issues/846#issuecomment-2371113163). Other than that, feel free to squash and merge.