config.ini -> /etc/fpsd.ini, a system file

freedomofpress / fingerprint-securedrop

A machine learning data analysis pipeline for analyzing website fingerprinting attacks and defenses.

GNU Affero General Public License v3.0

29 stars 9 forks source link

config.ini -> /etc/fpsd.ini, a system file #101

Closed psivesely closed 7 years ago

psivesely commented 7 years ago

Configuration is now done via a system file. Especially, with force: no (i.e., don't clobber) set in the Ansible task which sets this file up, it would be easy in the Vagrant environment to accidentally end up with a dirty config.ini. This prevents that.

conorsch commented 7 years ago

Super straightforward, I like! :100:

conorsch commented 7 years ago

Mode changes look good. FWIW I'd've set root:fpsd 640 so that only superusers can change the contents of the config file—allowing the service account to do that seems wonky. But this will work for our purposes and I'm fine with it going in. :+1:

coveralls commented 7 years ago

Coverage remained the same at 72.727% when pulling 68ce2e02d130a84e8efc6e6dd6ad29790fcef5fd on make-config-a-system-file into 938206f794d35b3ab861a47b0368217c42bec1e2 on master.

coveralls commented 7 years ago

Coverage remained the same at 72.727% when pulling 68ce2e02d130a84e8efc6e6dd6ad29790fcef5fd on make-config-a-system-file into 938206f794d35b3ab861a47b0368217c42bec1e2 on master.

coveralls commented 7 years ago

Coverage remained the same at 72.727% when pulling 68ce2e02d130a84e8efc6e6dd6ad29790fcef5fd on make-config-a-system-file into 938206f794d35b3ab861a47b0368217c42bec1e2 on master.