search

freedomofpress / fingerprint-securedrop

A machine learning data analysis pipeline for analyzing website fingerprinting attacks and defenses.
GNU Affero General Public License v3.0
29 stars 9 forks source link

Fix Crawler breakage caused by mis-configured Tor #70

Closed psivesely closed 8 years ago

psivesely commented 8 years ago

That #54 was not rebased on #66, which introduced a bug fixed in fbeb9d7. Mis-configuration of Tor via #66 caused the Firefox binary to crash leaving no Python traceback to help us figure out what was going on. Tor Browser Bundle (specifically TorButton) doesn't provide the best output for debugging, but after finding https://github.com/webfp/tor-browser-selenium/issues/62, I decided to set the Tor log to debug and take a close look. Tor was bootstrapping correctly, but it was still mis-configured, and that was causing TBB to crash.

I couldn't find anything in the selenium FF webdriver code that would allow me to get more debug info from TBB, but I probably should have looked to the documentation because selenium is very large, and it's probably just in another module. It's solved, anyway.

psivesely commented 8 years ago

Made a couple small typos in the last commit here at first, but now all tests are passing. Merging!