search

freedomofpress / securedrop-builder

Packaging logic for building SecureDrop-related Debian packages
GNU General Public License v3.0
7 stars 11 forks source link

Poetry logic does not fully account for underscores in package names #479

Closed eloquence closed 8 months ago

eloquence commented 9 months ago

Even with #474, our current poetry logic is still susceptible to inconsistencies in how dependencies may appear in pyproject.toml and poetry.lock.

Steps to reproduce

  1. In a Poetry-managed project, declare a dependency flit_core in pyproject.toml
  2. Update the lockfile
  3. Attempt to build the wheels

Expected behavior

New dependency will be picked up

Actual behavior

flit-core (which is how it appears in poetry.lock) is not picked up

eloquence commented 9 months ago

dbc7065ae6f7815e686c904de4bf8feee62fe6a1 is a stab at addressing this more comprehensively by canonicalizing names in our utility functions. However, I want to add some test cases before opening a PR, to ensure it's compatible with all cases we may encounter in the wild.