freedomofpress / securedrop-builder

Packaging logic for building SecureDrop-related Debian packages
GNU General Public License v3.0
7 stars 11 forks source link

Add pexpect-4.9.0 and ptyprocess-0.7.0 wheels and artifacts #488

Closed rocodes closed 7 months ago

rocodes commented 7 months ago

To reliably handle disk unlock and mount options in securedrop-export (sd-devices), I'm proposing to use pexpect, which depends on ptyprocess. We make use of this dependency on the securedrop side (dev-requirements, admin-dev requirements), but not as a production dependency.

I have done a review of both packages: https://github.com/freedomofpress/securedrop-builder/wiki/pexpect-4.9.0---ptyprocess-0.7.0

build logs (different build but same hashes) https://github.com/freedomofpress/build-logs/commit/72a91e2e9d1f1c25db105cec683964516570c2d3

Towards https://github.com/freedomofpress/securedrop-workstation/issues/265 Refs https://github.com/freedomofpress/securedrop-client/pull/1777