search

freedomofpress / securedrop-builder

Packaging logic for building SecureDrop-related Debian packages
GNU General Public License v3.0
7 stars 11 forks source link

Remove migrated CircleCI jobs and cleanup script #495

Closed eloquence closed 5 months ago

eloquence commented 5 months ago

That part of the job has been migrated to securedrop-yum-test . The remainder will be migrated to securedrop-workstation.

The cleanup script has been split into Debian and RPM portions, which are running in securedrop-apt-test and securedrop-yum-test, respectively.

Update 2024-04-15: Also removes the build/push jobs migrated via https://github.com/freedomofpress/securedrop-workstation/pull/955

eloquence commented 5 months ago

RPM build failure potentially related to 4.2 changes that just landed? Can poke tomorrow.

legoktm commented 5 months ago

RPM build failure potentially related to 4.2 changes that just landed? Can poke tomorrow.

Yep, and that further justifies putting that nightly logic into the workstation repo...probably we can do that and then come back to this cleanup? I did start in https://github.com/freedomofpress/securedrop-workstation/pull/955/, I think it just needs testing.

eloquence commented 5 months ago

Yep, and that further justifies putting that nightly logic into the workstation repo...probably we can do that and then come back to this cleanup? I did start in https://github.com/freedomofpress/securedrop-workstation/pull/955, I think it just needs testing.

OK, since this is directly tied to the 4.2 work, maybe best for you to take that one over the line, and I can take point if review unless someone else grabs it first?

Meanwhile, I can poke at the lint/reprotest jobs in this repo.

legoktm commented 5 months ago

OK, since this is directly tied to the 4.2 work, maybe best for you to take that one over the line, and I can take point if review unless someone else grabs it first?

Sounds good!

eloquence commented 5 months ago

Nightlies triggered directly from securedrop-workstation appear to be working, so I've also removed the build/push CircleCI config in this PR. Once this PR lands, I believe we can safely remove the SSH key associated with this repository as well, as I don't see it being used for anything else.