search

freedomofpress / securedrop-client

a Qt-based GUI for SecureDrop journalists 📰🗞️
GNU Affero General Public License v3.0
40 stars 39 forks source link

Empty Conversation View cut off after deleting a source #1233

Open sssoleileraaa opened 3 years ago

sssoleileraaa commented 3 years ago

STR

  1. minimize your client window
  2. delete a source
  3. wait until the deletion is complete and the "Select a source" screen appears

Expected

To be able to see all the "Select a source" text

Actual

"Select a source" text cut off Screenshot from 2021-03-29 11-02-57

Er1kkkaaa commented 2 years ago

Hi @creviera @eloquence I am trying to reproduce this issue but it seems to work fine on Ubuntu. Any suggestions?

sssoleileraaa commented 2 years ago

This is probably because you are testing against a different version of pyqt than what we use on our production qubes workstation environment. Since you're most likely running a newer OS, apt install python3-pyqt5 would likely install a later version of pyqt. Instead, you can try dpkg -i installing the exact version of .deb packages needed directly from a mirror, such as Oregon State University's Open Source Lab: http://http.us.debian.org/debian/pool/main/p/pyqt5/ (make sure to try this with the python3 version and not the python version). Afterwards, if you run apt-cache policy python3-pyqt5 in a terminal you should see:

python3-pyqt5:
  Installed: 5.11.3+dfsg-1+b3
  Candidate: 5.11.3+dfsg-1+b3
  Version table:
 *** 5.11.3+dfsg-1+b3 500
        500 http://deb.debian.org/debian buster/main amd64 Packages
        100 /var/lib/dpkg/status

Also, you'll need to use the .venv-debian virtual environment which you can create via make venv-debian. This virtual environment uses the system package for pyqt instead of installing it from PyPI like we do when you run make venv. I didn't realize that you couldn't use the regular .venv virtual environment to repro this issue, so thanks for the feedback! At this point, I think it would be best to direct you elsewhere until we do further testing with Ubuntu (or you can use a debian 10 virtual machine setup). If you really want to try it, you could timebox an investigation to see if you can get the client running with the 5.11.3+dfsg-1+b3 version of python3-pyqt5.

sssoleileraaa commented 2 years ago

Actually, surprisingly, I have another STR that will most likely work for you for your Ubuntu setup:

  1. Log into the client
  2. Delete a source account from the ... menu in the upper right-hand corner
  3. Wait for the "Select a source" screen to appear
  4. Shrink the client window to a size that cuts off the text