freedomofpress / securedrop-client

a Qt-based GUI for SecureDrop journalists 📰🗞️
GNU Affero General Public License v3.0
39 stars 37 forks source link

Support viewing of html files #2008

Open philmcmahon opened 1 year ago

philmcmahon commented 1 year ago

When opening a html file in securedrop workstation the viewer VM opens with a message:

Denied: qubes.OpenInVM

Since this VM is offline, would it be safe to just open the file in a browser? If not, gedit would be better than failing entirely, perhaps with a helpful message "Opening HTML files in a browser is considered unsafe" or similar

rocodes commented 1 year ago

Some options could include:

eaon commented 1 year ago

If we add Firefox to the mix of software we install into the large template, we would probably want to ship a hardened default profile as well. I'm thinking NoScript installed and enabled, maybe "blackholing" proxy settings to ensure that even if a DispVM somehow ends up with a network connection that loading resources doesn't happen out of the gate.

I don't think I'm a fan of showing folks HTML in gedit /gnome-text-editor, I think if we'd want to do that, processing the file with html2text first would be better.

zenmonkeykstop commented 1 month ago

Moving to securedrop-client. As a first iteration we should open the HTML in a text editor (gedit or similar), punting on the browser question for now.