add types to signal/slot tests

freedomofpress / securedrop-client

a Qt-based GUI for SecureDrop journalists 📰🗞️

GNU Affero General Public License v3.0

41 stars 39 forks source link

add types to signal/slot tests #225

Open heartsucker opened 5 years ago

heartsucker commented 5 years ago

If the signature of a signal/slot changes or they're called with different args, it will break in prod and we should do our best to test and ensure our types don't change.

eloquence commented 4 years ago

Discussed in backlog review today.

We do have types for many signals/slots now, but as with #25 (mypy type checks), it would be good to have a static check to generate a coverage report.

cfm commented 2 months ago

Discussed as a possible mypy plugin in python-qt-tools/PyQt5-stubs#68.