search

freedomofpress / securedrop-client

a Qt-based GUI for SecureDrop journalists 📰🗞️
GNU Affero General Public License v3.0
41 stars 39 forks source link

discard reply box text when changed to offline mode #601

Open deeplow opened 4 years ago

deeplow commented 4 years ago

Description

Consider edge-case when the journalist has typed stuff in the reply box and and logs out.

Following a discussion in https://github.com/freedomofpress/securedrop-client/issues/572#issuecomment-548093438 a more long term solution would be a dialog, but that is still in design. This issue is for the temporary solution of discarding the text

Steps to Reproduce

  1. open client (logged in)
  2. select source
  3. type reply (but don't send it)
  4. log out

Expected Behavior

Text is discarded and default placeholder show like so.

reply-new

Actual Behavior

The text you typed show up inside the disabled reply box.

eloquence commented 3 years ago

(Can confirm that this is still the current behavior in latest nightlies.)

cfm commented 2 months ago

NB. This is what most messaging apps mean by a "draft" message. Contrast with our DraftReply model, which is for messages either still outgoing or that previously failed to send.