freedomofpress / securedrop-client

a Qt-based GUI for SecureDrop journalists 📰🗞️
GNU Affero General Public License v3.0
41 stars 40 forks source link

Consider not running new syncs if jobs from previous sync are still active #800

Open eloquence opened 4 years ago

eloquence commented 4 years ago

We now kick off metadata syncs continuously, which is great. This also happens if we're still downloading replies/messages from a previous sync. This causes some additional complexity:

I'd like to discuss whether we want to preserve this behavior, or if it might be better to defer a sync until all jobs associated with the previous sync are completed.

From a user's point of view, the behavior seems to have limited value, as the user is already waiting for new content to arrive.

I realize syncs also serve the function of monitoring network state, so whether or not changing the behavior is viable may depend in part on the final logic we want to use for monitoring the network state and pausing the queues.

sssoleileraaa commented 4 years ago

this is somewhat a duplicate of https://github.com/freedomofpress/securedrop-client/issues/468

eloquence commented 4 years ago

I agree the issues are closely related, if we implemented either of the ideas in #468, this would seem to give us a straightforward way to change the behavior as described here.