freedomofpress / securedrop-dev-docs

SecureDrop Developer Documentation
Other
3 stars 3 forks source link

Document changes related to continuous localization #86

Closed nathandyer closed 7 months ago

nathandyer commented 10 months ago

Status

Work in progress

Closes https://github.com/freedomofpress/securedrop/issues/6916

Description of Changes

SecureDrop #6232

Testing

TK

Release

After merge:

Checklist (Optional)

nathandyer commented 10 months ago

Thanks for the initial review @cfm! I agree, so far I'm a big fan of the documentation-driven development approach! I'll be sure to go through and address all your line-level comments, but I wanted to make sure to answer your larger question before I sign off for the day, so we can plan our work accordingly.

I agree that incorporating an overview like this would be ideal, so that these newly unified processes can be documented in one central location. I'm going to set aside a period of time tomorrow morning to work on that, and should have it ready for you to take a look when you begin your day.

cfm commented 9 months ago

Per https://github.com/freedomofpress/securedrop/pull/6954#issuecomment-1749569876, we'll keep refining this documentation as part of the v2.7.0 release and plan to merge it afterwards, as we've done for past updates to the Localization Manager's procedures.

nathandyer commented 8 months ago

@cfm With the 2.7.0 release officially out in the world, are there any areas where the process diverged from what we have documented here? Is there anything else we need to change before flipping this to ready for review?

cfm commented 7 months ago

Back to you, @nathandyer!

nathandyer commented 7 months ago

Thank you so much @cfm, this all looks great. I left one small nitpick (a question really), but otherwise it LGTM.

This still shows as "Changes requested" from your review, but as far as I'm concerned, this is ready for an approve/merge, pending that one possible change mentioned above. If you feel this is ready, please don't hesitate to push the big scary button :)

cfm commented 7 months ago

Thanks, @nathandyer! Merging now, knowing that we can always revise later...or as soon as #112. :-)