Closed nathandyer closed 7 months ago
Thanks for the initial review @cfm! I agree, so far I'm a big fan of the documentation-driven development approach! I'll be sure to go through and address all your line-level comments, but I wanted to make sure to answer your larger question before I sign off for the day, so we can plan our work accordingly.
I agree that incorporating an overview like this would be ideal, so that these newly unified processes can be documented in one central location. I'm going to set aside a period of time tomorrow morning to work on that, and should have it ready for you to take a look when you begin your day.
Per https://github.com/freedomofpress/securedrop/pull/6954#issuecomment-1749569876, we'll keep refining this documentation as part of the v2.7.0 release and plan to merge it afterwards, as we've done for past updates to the Localization Manager's procedures.
@cfm With the 2.7.0 release officially out in the world, are there any areas where the process diverged from what we have documented here? Is there anything else we need to change before flipping this to ready for review?
Back to you, @nathandyer!
Thank you so much @cfm, this all looks great. I left one small nitpick (a question really), but otherwise it LGTM.
This still shows as "Changes requested" from your review, but as far as I'm concerned, this is ready for an approve/merge, pending that one possible change mentioned above. If you feel this is ready, please don't hesitate to push the big scary button :)
Thanks, @nathandyer! Merging now, knowing that we can always revise later...or as soon as #112. :-)
Status
Work in progress
i18n
repositories and branches does this workflow obsolete?Closes https://github.com/freedomofpress/securedrop/issues/6916
Description of Changes
Description: Documents new changes to the workflow as a result of the switch to continuous localization
Related Issues
SecureDrop #6232
Testing
TK
Release
After merge:
translations.rst
.Checklist (Optional)
make docs-lint
) passed locallymake docs-linkcheck
) passedmake docs
) docs at http://localhost:8000