Closed zenmonkeykstop closed 3 years ago
nginx changes look good! If it's at all helpful, I rebased nginx-fixes
on 060948a
(Forbidden Stories), so if someone wants to rebase on the latter they can drop my commits and merge
them back in without the [TEST]
junk in the commit message.
Tried this out in the latest alpha, rule changes show up - if @eloquence or someone else can take a look it would be good to get it merged on the off-chance the alpha period goes really quickly :)
I've got an alpha ready, will give it a spin.
Starting with the GitHub URL, of course I'm hitting the issue again where all onion names break after I change the Path Prefix - though "rulesets version" correctly set to 2021.6.30
OK, after troubleshooting with Kev, determined that the trick appears to be to wait a fairly significant time (up to ~1 minute) after adding the Path Prefix before trying an onion name again - the resolution of the ruleset date does not indicate that it's ready to use.
Status
Ready for review:
Signed with 2021 key, currently only supported by TBB Alpha
Review Checklist
onboarded.txt
are accuratedefault.rulesets.TIMESTAMP.gz
has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix
:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
index.html
has been updated using./update_index.sh
Post-Deployment Checklist