freedomofpress / securedrop-https-everywhere-ruleset

HTTPS Everywhere ruleset for human-readable Onion URLs for SecureDrop instances
https://securedrop.org/https-everywhere/
10 stars 3 forks source link

Backports addition of Forbidden Stories #58

Closed zenmonkeykstop closed 3 years ago

zenmonkeykstop commented 3 years ago

Status

Ready for review:

Signed with 2021 key, currently only supported by TBB Alpha

Review Checklist

Post-Deployment Checklist

maeve-fpf commented 3 years ago

nginx changes look good! If it's at all helpful, I rebased nginx-fixes on 060948a (Forbidden Stories), so if someone wants to rebase on the latter they can drop my commits and merge them back in without the [TEST] junk in the commit message.

zenmonkeykstop commented 3 years ago

Tried this out in the latest alpha, rule changes show up - if @eloquence or someone else can take a look it would be good to get it merged on the off-chance the alpha period goes really quickly :)

eloquence commented 3 years ago

I've got an alpha ready, will give it a spin.

eloquence commented 3 years ago

Starting with the GitHub URL, of course I'm hitting the issue again where all onion names break after I change the Path Prefix - though "rulesets version" correctly set to 2021.6.30

eloquence commented 3 years ago

OK, after troubleshooting with Kev, determined that the trick appears to be to wait a fairly significant time (up to ~1 minute) after adding the Path Prefix before trying an onion name again - the resolution of the ruleset date does not indicate that it's ready to use.