search

freedomofpress / securedrop-https-everywhere-ruleset

HTTPS Everywhere ruleset for human-readable Onion URLs for SecureDrop instances
https://securedrop.org/https-everywhere/
10 stars 3 forks source link

Add FT onion name #74

Closed conorsch closed 2 years ago

conorsch commented 2 years ago

Status

Ready for review

Closes #73

Review Checklist

Post-Deployment Checklist

eloquence commented 2 years ago

:x: The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME

Unfortunately this part doesn't work for me. This is likely entirely unrelated to the PR - I've always found Tor Browser very finicky when it comes to configuring the dev ruleset. It usually requires a browser restart as well as a couple of minutes delay. But even with multiple restarts it doesn't work for me this time around -- onion names are just completely borked after I make the change to https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/73-let-there-be-ft, with or without the / at the end.

Screenshot from 2021-11-24 11-48-42

It's possible that my extension is now in an unrecoverable state and I'll have to try with a fresh browser install - but I'd appreciate if someone else could take a spin. Given how fragile HTTPSE is in this respect, we may want to document the exact steps a bit more clearly in the PR template.

zenmonkeykstop commented 2 years ago

I'll review now.

zenmonkeykstop commented 2 years ago

Seeing the same behavior, with the added wrinkle that even after changing back to the https://securedrop.org/https-everywhere-2021/ prefix, onion names stay b0rked.

eloquence commented 2 years ago

Yeah, same here. Possible that our test workflow is no longer supported :/

zenmonkeykstop commented 2 years ago

works when going from default to a previous branch's ruleset (tested the add-aj-2021 branch specifically) - but that's the same ruleset as is in the default right now so it may just not have refreshed anything!

zenmonkeykstop commented 2 years ago

Oh, never mind, it's working for me now.