Closed conorsch closed 2 years ago
Without a doubt, not sure how that happened. Will fix and regenerate.
The problem only occurs for the CNN entry because the API is returning a protocol for only that entry:
$ curl -s https://securedrop.org/api/v1/directory/ | jq -r '.[].onion_address' | grep http | wc -l
1
and the onboarding script assumes there's no protocol on the onion field. See related discussion in https://github.com/freedomofpress/securedrop.org/pull/878. While we could easily update the onboarding script to be more forgiving, in this case, I'm going to edit the db entry so that the API returns consistent results across the board. At a later date, we can decide whether we want to enforce stronger validation on that field for future updates.
After updating, I'll regenerate and resign, as stated above.
@eloquence Updated as described. Please test again, it should work now.
:facepalm: I never rm
'd the irozhlas file. Merely removing from onboarding allows the script to complete successfully, but doesn't change the contents of the tarball. Fixing...
@eloquence Once more, I beseech you: test.
Status
Ready for review. Contains two changes:
Review Checklist
onboarded.txt
are accuratedefault.rulesets.TIMESTAMP.gz
has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix
:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
index.html
has been updated using./update_index.sh
Post-Deployment Checklist