search

freedomofpress / securedrop-signal-poc

prototype e2e server and source + journalist clients for securedrop
GNU General Public License v3.0
5 stars 3 forks source link

Remove unnecessary serde::Deserialize implementations #32

Closed legoktm closed 2 years ago

legoktm commented 2 years ago

These structs/enums are only ever serialized AFAICT, so they don't need a Deserialize implementation. This should speed up compile times a bit and reduce the overall binary size.

legoktm commented 2 years ago

Thanks! One thing I was curious about but didn't think to ask earlier is whether all these structs actually need to be pub. IIRC the compiler would have flagged Deserialize as being unused if it knew the structs were only used in this crate.