freedomofpress / securedrop

GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!

https://securedrop.org/

Other

3.6k stars 686 forks source link

Closed thomasha closed 7 years ago

thomasha commented 7 years ago

Bug

The xml file aliases-config-pfSense.xml is missing the starting tag.

The file starts with aliases> should start with <aliases>

thomasha commented 7 years ago

There is also an mistyping in the interfaces-config-pfSense.xml file, if following the guide, the subnet on OPT1 is set to 32, but should be 24.

<opt1>
    <if>igb2</if>
    <descr>OPT1</descr>
    <enable/>
    <ipaddr>10.20.2.1</ipaddr>
    <subnet>32</subnet>
    <spoofmac/>
</opt1>

redshiftzero commented 7 years ago

Good catches @thomasha, will fix. Let us know if you spy anything else off with the templates.

redshiftzero commented 7 years ago

Relevant: #2282. Added to 0.4.4 milestone.

redshiftzero commented 7 years ago

Actually, we should still use the firewall templates as a reference, so I went ahead and fixed this in #2283.

redshiftzero commented 7 years ago

Fixed by #2283