search

freedomofpress / securedrop

GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!
https://securedrop.org/
Other
3.62k stars 685 forks source link

Future proof button styling for languages with connected scripts #2390

Open redshiftzero opened 7 years ago

redshiftzero commented 7 years ago

Description

The buttons were fixed in #2385 to render well for Arabic, but this will need to be edited for other languages if we translate SecureDrop into languages that use a script with connected letters. Here's a suggestion from @heartsucker in this comment:

// we have to use two to make it a list otherwise sass complains
$no_space_locales: ar fa
@each $locale in $no_space_locales
  &:lang(locale)
    letter-spacing: 0em
eloquence commented 3 years ago

This could still be relevant as part of SASS cleanup as we expand language support, keeping open.

eaon commented 2 years ago

We dropped SASS recently so no more loops for us. But, @cfm, I'm wondering if there's some other way to integrate with Weblate to automate making appropriate changes to the static CSS files?

cfm commented 2 years ago

On Fri, Nov 04, 2022 at 08:06:00PM -0700, eaon wrote:

We dropped SASS recently so no more loops for us. But, @cfm, I'm wondering if there's some other way to integrate with Weblate to automate making appropriate changes to the static CSS files?

Not that I can tell from Weblate's add-ons (https://docs.weblate.org/en/latest/admin/addons.html). But now that we have our own "i18n.json" configuration, we could add custom keys there for use in a Jinja-rendered "l10n.css"....